Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker-compose installation script and modified scripts #754

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

mhmdksh
Copy link
Collaborator

@mhmdksh mhmdksh commented Dec 22, 2022

No description provided.

@mhmdksh
Copy link
Collaborator Author

mhmdksh commented Dec 22, 2022

@kristoferlund @nebs-dev Your help on this would be much appreciated, this is like a prerequisite to make everything work for the multi-container hosted server

kristoferlund
kristoferlund previously approved these changes Dec 26, 2022
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this using v2 version of Docker Compose? I thought docker-compose meant using the old version of compose?

But if I have misunderstood that, please go ahead and merge, looks good!

@mhmdksh
Copy link
Collaborator Author

mhmdksh commented Dec 26, 2022

Is this using v2 version of Docker Compose? I thought docker-compose meant using the old version of compose?

But if I have misunderstood that, please go ahead and merge, looks good!

@kristoferlund Yeah after checking it out, apparently docker compose is meant to be an upgrade to the original docker-compose to Go.
The versions though are still the same, I thought just using the normal docker-compose now is better with multi-instance setup, as (docker compose) needs specific configuration for every user running it (Which is not so convenient).

Before I merge this, I'll be adding 1 more commit, that will enhance the .env setup to be compatible with multi instance in which it make every instance running on the same server have unique names/ports etc.. to container duplication

nebs-dev
nebs-dev previously approved these changes Dec 26, 2022
@mhmdksh mhmdksh dismissed stale reviews from nebs-dev and kristoferlund via bbd46f2 December 26, 2022 13:35
@kristoferlund kristoferlund merged commit 04afd6f into main Dec 28, 2022
@kristoferlund kristoferlund deleted the script-housekeeping branch December 28, 2022 09:17
@kristoferlund kristoferlund mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants